Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promote drift to stable #1311

Merged
merged 10 commits into from
Jun 11, 2024
Merged

feat: promote drift to stable #1311

merged 10 commits into from
Jun 11, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Jun 9, 2024 •
edited
Loading

Fixes #N/A

Description
Removes the feature gating of Drift. Will need to update values.yaml in cloudprovider specific karpenter.

How was this change tested?
Deployed to local karpenter and unit testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rschalo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 9, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2024
@rschalo rschalo marked this pull request as ready for review June 10, 2024 13:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2024
jonathan-innis
jonathan-innis approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis, rschalo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2129147 into kubernetes-sigs:staging/v1 Jun 11, 2024
12 checks passed
rschalo added a commit to rschalo/karpenter that referenced this pull request Jun 24, 2024
@rschalo
feat: promote drift to stable (kubernetes-sigs#1311)
1c8ecf6
rschalo added a commit to rschalo/karpenter that referenced this pull request Jun 24, 2024
@rschalo
feat: promote drift to stable (kubernetes-sigs#1311)
d2f8e6d
BEvgeniyS pushed a commit to BEvgeniyS/karpenter that referenced this pull request Jul 5, 2024
@rschalo @BEvgeniyS
feat: promote drift to stable (kubernetes-sigs#1311)
70296ca
@rschalo rschalo mentioned this pull request Jul 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@engedaam engedaam Awaiting requested review from engedaam

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@jmdeal jmdeal Awaiting requested review from jmdeal

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@jonathan-innis jonathan-innis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rschalo @k8s-ci-robot @jonathan-innis